Fix incorrect highlight.js overrides #4624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
iadawn
approved these changes
Sep 23, 2025
| <h4>The JavaScript</h4> | ||
|
|
||
| <pre xml:space="preserve"><code class="language-javascript"><script> | ||
| <pre xml:space="preserve"><code class="language-html"><script> |
There was a problem hiding this comment.
Wouldn't this be better as language-javascript? Seems there is much more JS than HTML
There was a problem hiding this comment.
What matters isn't how much there is, but that there's a <script> tag around it. This inherently makes this an HTML block.
Same for instances of CSS surrounded by <style>. The xml language support is capable of understanding JS and CSS within appropriate contexts, but the reverse is not true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes instances where we had specified the wrong
language-...class in<pre><code class="...">, causing highlight.js to highlight code incorrectly.(Originally fixed/reported in #4611, which is being split up and closed)